Release/1.0.4 #11
Merged
Release/1.0.4 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This is a release preparation pull request that bumps the version to 1.0.4 and includes various improvements and fixes to the IncrementalGeneratorExtensions package.
- Version bump from 1.0.3 to 1.0.4 with package metadata fixes
- Enhanced EquatableImmutableArray instance cache with a new two-level caching strategy
- Added generator name and version information to auto-generated code comments
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| version.props | Updates version prefix to 1.0.4 |
| global.json | Simplifies SDK configuration by removing prerelease settings |
| IncrementalGeneratorExtensions.csproj | Reorders PackageProjectUrl property for consistency |
| SourceTextGeneratorBase.cs | Adds assembly metadata extraction for generator identification |
| GeneratorStageDescriptions.cs | Updates stage descriptions and adds new embedded attribute stage |
| GeneratorStage.cs | Adds PostInitializationContextAddEmbeddedAttributeDefinition enum value |
| EquatableImmutableArrayInstanceCache.cs | New file implementing optimized two-level instance cache |
| EquatableImmutableArray.cs | Refactors to use external cache implementation |
| CHANGELOG.md | Documents release changes and updates version links |
Comments suppressed due to low confidence (1)
IncrementalGeneratorExtensions.Content/Datacute/IncrementalGeneratorExtensions/EquatableImmutableArrayInstanceCache.cs:29
- [nitpick] The variable name 'Cache' is too generic for a complex nested data structure. Consider a more descriptive name like 'LengthToFirstElementHashCache' or 'TwoLevelInstanceCache' to clarify its purpose.
private static readonly ConcurrentDictionary<int, ConcurrentDictionary<int, List<WeakReference<EquatableImmutableArray<T>>>>> Cache =
...ions.Content/Datacute/IncrementalGeneratorExtensions/EquatableImmutableArrayInstanceCache.cs
Outdated
Show resolved
Hide resolved
...neratorExtensions.Content/Datacute/IncrementalGeneratorExtensions/SourceTextGeneratorBase.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.